On Fri, 21 Apr 2017, Segher Boessenkool wrote: >>> + <li>There are new options <code>-mstack-protector-guard=global</code>, >>> + <code>-mstack-protector-guard=tls</code>, >>> + <code>-mstack-protector-guard-reg=</code>, and >>> + <code>-mstack-protector-guard-offset=</code>, to change how the stack >>> + protector gets the value to use as canary.</li> >> no comma before "to change". > Oxford comma :-) I'll get rid of it, sure.
The comma before "and" (and the last item in the list) is an Oxford comma, and I'm all for keeping it. The one before "to change" would be an Amsterdam comma. :-) >> Well, one question: Don't these options do more than just changing >> how the value is obtained? The way I read the documentation the first >> two initiate generation of stack protection code? Am I confused, or >> should either the web patch or the documentation be adjusted? > No, this is correct. The documentation could be clearer yes. I'll > try to improve it; help is more than welcome ;-) I'll volunteer myself to review any patch (to see whether it helps improve my understanding and otherwise), but am afraid I can't come up with one. Gerald
