On 17 Jul, David Malcolm wrote: > On Sun, 2017-07-16 at 12:13 +0200, Volker Reichelt wrote: >> Hi, >> >> this is PING^4 for a C++ patch that adds fix-it hints for wrong usage >> of 'friend' and 'auto': >> >> https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01575.html > > I notice that the patch slightly changes the apparent indentation > within the RID_AUTO hunk, but the pre-existing lines there are a > mixture of pure spaces, and tabs+spaces; please double-check that any > lines that the patch touches are converted to correctly follow our > convention of tabs+spaces.
The indentation in that area needs quite some tabs vs. spaces cleanup. I only fixed the lines that are touched by the code changes (and also the comment above in the final commit). > Other than that, OK for trunk. Committed to trunk. Regards, VOlker > Sorry for not spotting this earlier. > Dave > >> Previous pings >> >> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01248.html >> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00207.html >> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00712.html ; (by >> Gerald) >> >> (thanks Gerald!) >> >> Regards, >> Volker >