Hi Carl, Some comments, mostly trivial:
On Thu, Sep 21, 2017 at 04:09:11PM -0700, Carl Love wrote: > --- a/gcc/config/rs6000/rs6000-builtin.def > +++ b/gcc/config/rs6000/rs6000-builtin.def > @@ -608,6 +608,16 @@ > CODE_FOR_ ## ICODE) /* ICODE */ > > > +/* Miscellaneous builtins for instructions added prior to ISA 2.04. These > + operate on floating point registers. */ "operate" should align with "Miscellaneous". > +#define BU_FP_MISC_1(ENUM, NAME, ATTR, ICODE) > \ > + RS6000_BUILTIN_1 (MISC_BUILTIN_ ## ENUM, /* ENUM */ \ > + "__builtin_" NAME, /* NAME */ \ > + RS6000_BTM_HARD_FLOAT, /* MASK */ \ > + (RS6000_BTC_ ## ATTR /* ATTR */ \ > + | RS6000_BTC_UNARY), \ > + CODE_FOR_ ## ICODE) /* ICODE */ RS6000_BTM_HARD_FLOAT needs to be indented one extra space, too. > +(define_insn "lrintsfsi2" > + [(set (match_operand:SI 0 "gpc_reg_operand" "=d") > + (unspec:SI [(match_operand:DF 1 "gpc_reg_operand" "d")] > + UNSPEC_FCTIW))] > + "TARGET_SF_FPR && TARGET_FPRND" > + "fctiw %0,%1" > + [(set_attr "type" "fp")]) Should this be match_operand:SF? Okay for trunk if that works. Thanks, Segher
