On 02/08/2018 04:04 AM, Nick Clifton wrote:
Hi David,

+         /* PR 84195: Replace control characters in the message with their
+            escaped equivalents.  Allow newlines if -fmessage-length has
+            been set to a non-zero value.

I'm not quite sure why we allow newlines in this case, sorry.

Because the documentation for -fmessage-length says:

  Try to format error messages so that they fit on lines
  of about N characters.  If N is zero, then no
  line-wrapping is done; each error message appears on a
  single line.  This is the default for all front ends.

So with a non-zero message length, multi-line messages are allowed.

At least that was my understanding of the option.

It would be helpful to mention this somehow in the documentation
of each of the #-directives (i.e., that control characters are
escaped including newlines, subject to -fmessage-length).
Unless you want to handle that as part of the patch I'll see
about submitting a docs only change for the affected bits once
these bits have been committed.


Thanks for the patch review.  I will get onto fixing the points you
raised today.


Reply via email to