On Mon, Mar 11, 2019 at 02:25:59PM +0100, Martin Liška wrote:
> @@ -38375,7 +38375,7 @@ rdseed_step:
> mode0 = insn_data[icode].operand[0].mode;
> if (!insn_data[icode].operand[0].predicate (op0, mode0))
> {
> - error ("the xabort's argument must be an 8-bit immediate");
> + error ("the xabort%'s argument must be an 8-bit immediate");
> return const0_rtx;
> }
> emit_insn (gen_xabort (op0));
I'd drop the 's here instead and maybe the as well?
> --- a/gcc/d/dmd/expressionsem.c
> +++ b/gcc/d/dmd/expressionsem.c
> @@ -1366,7 +1366,7 @@ public:
> }
> else
> {
> - exp->error("new can only create structs, dynamic arrays or class
> objects, not %s's", exp->type->toChars());
> + exp->error("new can only create structs, dynamic arrays or class
> objects, not %s%'s", exp->type->toChars());
> return setError();
> }
>
I think for D you need to go through Iain Buclaw, I have no idea if
exp->error even has the gcc internal format infrastructure. Can you split
that part of the patch and post it independently?
Otherwise LGTM.
Jakub
