On 01/08/2019 12:19, Bernd Edlinger wrote:
On 7/31/19 3:16 PM, Richard Earnshaw (lists) wrote:
On 30/07/2019 21:51, Bernd Edlinger wrote:
+/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft
-mabi=aapcs -O3" } */
This isn't going to work as-is, we test many combinations of the compiler,
either with explicit dejagnu settings or with the compiler defaults and the
dejagnu settings can't generally be overridden this way.
For -marm you require an effective-target of arm_arm_ok. For ldrd, it should
be enough to just require an effective-target of arm_ldrd_strd_ok, then you can
.
I don't think we really care about any ABIs other than aapcs, so I'd just leave
that off. And as for setting the float-abi, I don't see anything in the tests
that would require that, so that can probably be omitted as well.
I think with all this, you can then write something like
/* { dg-require-effective-target arm_arm_ok && arm_ldrd_strd_ok } */
/* { dg-options "-marm -mno-unaligned-access -O3 } */
But I haven't tested that, so you might need to fiddle with it a bit,
especially the effective-target rule.
Okay, it seems we need two dg-require-effective-target rules for this to work,
as in the attached new version of the patch which I am currently boot-strapping.
Is it OK for trunk after successful boot-strap and reg-testing?
The tests are OK. If the match rules for the stm instruction turn out
to cause problems I think we can just drop them without materially
weakening the tests. But lets wait and see on that.
I'll leave the mid-end bits to Richi, I'm not familiar with that code.
R.
Thanks
Bernd.
