On 8/12/19 9:21 AM, Dragan Mladjenovic wrote: > On 09.08.2019. 23:31, Jeff Law wrote: >> On 8/5/19 4:47 AM, Dragan Mladjenovic wrote: >>> From: "Dragan Mladjenovic" <dmladjeno...@wavecomp.com> >>> >>> gcc/ChangeLog: >>> >>> 2019-08-05 Dragan Mladjenovic <dmladjeno...@wavecomp.com> >>> >>> * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to >>> TARGET_SOFT_FLOAT. >>> * config/mips/mips.c (TARGET_ASM_FILE_END): Define to ... >>> (mips_asm_file_end): New function. Delegate to >>> file_end_indicate_exec_stack if NEED_INDICATE_EXEC_STACK is true. >>> * config/mips/mips.h (NEED_INDICATE_EXEC_STACK): Define to 0. >>> >>> libgcc/ChangeLog: >>> >>> 2019-08-05 Dragan Mladjenovic <dmladjeno...@wavecomp.com> >>> >>> * config/mips/gnustack.h: New file. >>> * config/mips/crti.S: Include gnustack.h. >>> * config/mips/crtn.S: Likewise. >>> * config/mips/mips16.S: Likewise. >>> * config/mips/vr4120-div.S: Likewise. >> Seems reasonable. What testing has been done for this patch? I don't >> doubt it works for the MIPS linux targets, I'm more interested in making >> sure it doesn't do the wrong thing for the embedded mips targets. > > I've built a cross mips-mti-elf toolchain, albeit with reduced multilib, > but still there were not .note.GNU-stack in sysroot. > Is this enough? Yea. Mostly just wanted to make sure the *-elf targets still build -- I didn't expect problems, but it's good to have sanity checking.
> > > > > Do you have write access to the repository? > > > > I do not have write access to the repository. We should probably fix that. https://sourceware.org/cgi-bin/pdw/ps_form.cgi List me as your sponsor. jeff