> On Tue, Nov 19, 2019 at 07:29:37AM +0100, Jan Hubicka wrote: > > Current patch makes GCC to accept symver attribute on all ELF targets > > and simply output .symver directive into the assembly file hoping for > > the best. I hope that is acceptable since user will be informed by > > assembler that symver is not supported. > > > > For testsuite we however needs tests to not fail when .symver is not > > accepted by assembler that can probably by tested by the dg-require > > infrastructure... > > > > It is not perfect solution but also not much worse than what we do > > elsewhere... > > Sounds perfectly fine to me, but how many tests will need changing? Is > it only those that use symbol versioning directly?
There are no tests presently, I plan to write some so those will get dg-require-symver. .symver is output only if you use explicit symver function/variable attribute. So the "only" downdisde of this is that instead of getting friendly error message from GCC that your target does not support symvers (because we can not easily check for it) you will get less friendly error message from assembler. I hope that is acceptale since we have pre-existing situations like that already. Honza > > > Segher
