On Tue, Nov 19, 2019 at 10:19:05AM -0600, Segher Boessenkool wrote:
> On Tue, Nov 19, 2019 at 03:53:43PM +0100, Jan Hubicka wrote:
> > > Sounds perfectly fine to me, but how many tests will need changing? Is
> > > it only those that use symbol versioning directly?
> >
> > There are no tests presently, I plan to write some so those will get
> > dg-require-symver.
> >
> > .symver is output only if you use explicit symver function/variable
> > attribute. So the "only" downdisde of this is that instead of getting
> > friendly error message from GCC that your target does not support
> > symvers (because we can not easily check for it) you will get less
> > friendly error message from assembler. I hope that is acceptale since
> > we have pre-existing situations like that already.
>
> Ah, I thought this would happen for various things from libc as well, so
> there would be a lot of random fallout. I probably misunderstood :-)
glibc so far uses inline asm with .symver directives. That could change one
day of course conditionally to use the GCC symver attribute.
Jakub
