On Thu, 2019-11-21 at 21:43 -0500, David Malcolm wrote: > This is the column number as reported in the diagnostic i.e the > COL_NUM > when printing e.g. > warning: FILENAME:LINE_NUM:COL_NUM: some message > > It seems to me that PR 49973 and this patch cover two separate > things:
On re-reading, I think I worded this poorly "both PR 49973 and this patch", I meant to say (I didn't want to say that the patch isn't for PR 49973, it's just that that PR covers two things, if that makes sense). > (a) bytes vs display columns in diagnostic-show-locus.c > (b) the "COL_NUM" mentioned above. > > I'd prefer to omit (b) from the patch, and have the focus of the > patch > be (a), to tackle (b) in a separate patch.
