On Sat, 29 Aug 2020, Hu Jiangping wrote:
> This patch add 'cd' command before 'make check-gcc' command
> when run the testsuite on selected tests.
No, don't do that; those targets work fine from the toplevel
too, and then include the language libs.
> Richard and I agree it would be good for clarity and
> emphasis to have the cd in the example as well, although
> the text above the example was trying to restrict that to
> objdir/gcc.
Aha, I guess you misinterpreted the existing "cd @var{objdir};
make -k check", because I see no /gcc there.
Please remove the /gcc from the patch.
Some <specific>.exp just exist in the gcc dir, but that's not
the point of these examples and the extra iteration from the
toplevel doesn't take more than a second or two. The bigger
risk is missing testing in the target libraries.
(Incidentally, while GNU make is required such that "-C objdir"
would be equivalent, for newcomers I agree the "cd" is
clearer in examples.)
brgds, H-P
