Hi, H-P
> > > On Sat, 29 Aug 2020, Hu Jiangping wrote:
> > >
> > > > This patch add 'cd' command before 'make check-gcc' command
> > > > when run the testsuite on selected tests.
> > >
> > > No, don't do that; those targets work fine from the toplevel
> > > too, and then include the language libs.
> > Yes, I know that 'make check-gcc' work well from the toplevel,
> > but 'make check-g++' does not. Is there anything wrong with
> > the Makefile?
>
> IIUC check-g++ is somewhat a historic artefact, but for
> consistency it should be added to the toplevel Makefile too as
> a synonym for check-c++.
Thanks for your suggestion. I'm submitting a patch for that.
Any advice will be appreciated.
>
> > i.e.:
> > Note that if run 'make check-testsuite' from the object directory,
> > not only the tests under gcc subdirectory but also the tests under
> > the target libriaries will be performed.
>
> (There's no "make check-testsuite".)
Oh, I mean 'check-@var{testsuite}'.
If the patch for Makefile is ok, then the patch here will be modified
accordingly.
For example, it is no need to add cd objdir/gcc before the ‘make
check-<testsuite>’
commands, but in the text above the commands we need to describe the difference
between the targets in the gcc subdirectory and the object directory.
Regards!
Hujp
>
> > What do you think?
>
> I think that after re-reading the patch, I retract my objection,
> thanks.
>
> FWIW, note also "check-gcc-<LANGUAGE>" where LANGUAGE="c, c++,
> fortran, ada" which do consider the library testsuite.
>
> brgds, H-P
>
