On Wed, Oct 28, 2020 at 7:21 PM Carl Love <c...@us.ibm.com> wrote:
>
> David:
>
> On Sat, 2020-10-24 at 11:29 -0400, David Edelsohn wrote:
> > Hi, Carl
> >
> > Not commenting on the implementation.
> >
> > Please stop using powerpc*-*-* in the test cases. The test cases
> > already are in the gcc.target/powerpc directory.
> >
> > Do the test cases really need lp64, or should this require something
> > like int128?
> >
> > Thanks, David
>
> OK, I looked at the test case and it really needs 128-bit integer
> support. I changed the test case header to:
>
> +++ b/gcc/testsuite/gcc.target/powerpc/bcd-4.c
> @@ -0,0 +1,519 @@
> +/* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target power10_hw } */
> +/* { dg-options "-mdejagnu-cpu=power10 -O2" } */
>
> I reran the regression test. There were no regressions. Does the
> above look more reasonable?
Better, but please use
/* { dg-require-effective-target int128 } */
not "target int128" in the selector. Segher and I both agree that
it's cleaner and more readable. The selector (the target part on the
dg-do line) should not be used for this type of requirement.
Thanks David
