On 12/21/21 12:33, Andrew Stubbs wrote:
On 20/12/2021 15:58, Andrew Stubbs wrote:
In order to support the %dynamic_smem_size PTX feature is is necessary
to bump the minimum supported PTX version from 3.1 (~2013) to 4.1
(~2014).
Tobias has pointed out, privately, that the default version is both
documented and encoded in the -mptx option, so I need to fix that too.
This patch adds -mptx=4.1, sets it as the default, and updates the
documentation accordingly.
The -mptx=3.1 option is kept for backwards compatibility as an alias for
4.1. There's no point in actually allowing 3.1 as any program linked
against libgomp will fail (and that's all offloading programs).
OK for stage 1?
Just keep -mptx=3.1 as is, and add -mptx=4.1.
AFAIU, there's actually only one file required to have -mptx=4.1, the
one using %dynamic_smem_size. Since it's somewhat cumbersome to add
flags for a single file, how about:
...
diff --git a/libgomp/configure.tgt b/libgomp/configure.tgt
index d4f1e741b5a..92242697f24 100644
--- a/libgomp/configure.tgt
+++ b/libgomp/configure.tgt
@@ -162,6 +162,7 @@ case "${target}" in
nvptx*-*-*)
config_path="nvptx accel"
+ XCFLAGS="$XCFLAGS -mptx=4.1"
;;
*-*-rtems*)
...
?
Thanks,
- Tom
