Hi Rasmus,

> On 17 Dec 2021, at 13:49, Rasmus Villemoes <rasmus.villem...@prevas.dk> wrote:
> 
> In the end, we ended up adding a two-argument overload for C++ only, as
> this is/was only relevant for getting libstdc++ (more specifically, the
> new filesystem abstraction stuff) to build. That is, we added
> 
> +#if __GNUC__ > 6 && defined(__cplusplus)
> +extern "C++" {
> +extern int      open (const char *name, int flags);
> +}
> +#endif
> +
> 
> to fcntl.h, and added a trivial definition of that (which calls the
> tree-argument form with a 0 for mode) to the OS build. I guess it could
> also have been an inline.

I experimented with the inline track (patch attached) and we're
having good results with it. It builds and test results we get
are on par with those we had with the varargs approach.

Works better for you?  Thanks again for raising the point.

Cheers,

Olivier


2021-01-10  Olivier Hainque  <hain...@adacore.com>
            Rasmus Villemoes  <rasmus.villem...@prevas.dk>

        * inclhack.def (vxworks_posix_open): New hack.
        * tests/base/fcntl.h: Update.
        * fixincl.x: Regenerate.

Attachment: 0003-Add-VxWorks-fixincludes-hack-open-posix-API.patch
Description: Binary data

Reply via email to