on 2022/1/14 下午9:53, David Edelsohn wrote: > On Fri, Jan 14, 2022 at 5:42 AM Kewen.Lin <li...@linux.ibm.com> wrote: >> >> on 2022/1/13 下午11:15, David Edelsohn wrote: >>> On Thu, Jan 13, 2022 at 7:40 AM Kewen.Lin <li...@linux.ibm.com> wrote: >>>> >>>> Hi David, >>>> >>>> on 2022/1/13 上午11:12, David Edelsohn wrote: >>>>> On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin <li...@linux.ibm.com> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> This patch is to clean up some codes with GET_MODE_UNIT_SIZE or >>>>>> GET_MODE_NUNITS, which can use known constant instead. >>>>> >>>>> I'll let Segher decide, but often the additional code is useful >>>>> self-documentation instead of magic constants. Or at least the change >>>>> requires comments documenting the derivation of the constants >>>>> currently described by the code itself. >>>>> >>>> >>>> Thanks for the comments, I added some comments as suggested, also removed >>>> the whole "altivec_vreveti2" since I noticed it's useless, it's not used >>>> by any built-in functions and even unused in the commit db042e1603db50573. >>>> >>>> The updated version has been tested as before. >>> >>> As we have discussed offline, the comments need to be clarified and >>> expanded. >>> >>> And the removal of altivec_vreveti2 should be confirmed with Carl >>> Love, who added the pattern less than a year ago. There may be another >>> patch planning to use it. >>> >> >> Thanks for the suggestions David! The comments have been updated, and Carl >> also helped to confirm the altivec_vreveti2 pattern is not planned for any >> future work and looks reasonable to remove. >> >> Does this updated version look good to you? > > The revised patch is okay.
Thanks! Committed as r12-6621. BR, Kewen
