Hi Andre,
your patch breaks bootstrapping:
../../repos/gcc/gcc/fortran/trans-array.cc: In function ‘tree_node*
structure_alloc_comps(gfc_symbol*, tree, tree, int, int, int,
gfc_co_subroutines_args*)’:
../../repos/gcc/gcc/fortran/trans-array.cc:9200:42: error: ‘cdesc’ may be used
uninitialized [-Werror=maybe-uninitialized]
9200 | gfc_conv_descriptor_data_set (&tmpblock, cdesc, comp);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
../../repos/gcc/gcc/fortran/trans-array.cc:9082:16: note: ‘cdesc’ was declared
here
9082 | tree cdesc;
| ^~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [Makefile:1143: fortran/trans-array.o] Error 1
Tobias
On 28.01.22 10:07, Andre Vehreschild via Fortran wrote:
Hi Harald,
thanks for the fast review. I have submitted as c9c48ab7bad.
Will wait for two weeks (reminder set :-)) before backporting to gcc-11.
Thank you and regards,
Andre
On Tue, 25 Jan 2022 22:30:22 +0100
Harald Anlauf via Fortran <fort...@gcc.gnu.org> wrote:
Hi Andre',
Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran:
Hi all,
attached patch fixes wrong code generation when broadcasting a derived type
containing allocatable and non-allocatable scalars. Furthermore does it
prevent broadcasting of coarray-tokens, which are always local this_image.
Thus having them on a different image makes no sense.
Bootstrapped and regtested ok on x86_64-linux/F35.
Ok, for trunk and backport to 12 and 11-branch after decent time?
I perceived that 12 is closed for this kind of bugfix, therefore asking ok
for 13.
I do not think that 12 is closed for bugfixing, especially not for
fortran. And if my cursory reading of the patch is not misleading,
the impact of the patch is really limited to coarrays.
You may want to wait for another 1-2 days for additional comments.
If not, it is OK from my side.
Thanks for the patch!
Harald
Regards,
Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
--
Andre Vehreschild * Email: vehre ad gmx dot de
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
