On 03/14/2012 12:22 PM, H.J. Lu wrote:
> On Fri, Mar 2, 2012 at 10:00 AM, H.J. Lu <hongjiu...@intel.com> wrote:
>> Hi,
>> This patch adds --with-abi= support to x86_64-*-* to configure GCC with
>> --with-abi=x32
>> --with-abi=mx32
>> --with-multilib-list=mx32
>> to set the default ABI to x32.  In i386 backend, ISA_64BIT is used to
>> generate i386 code or x86-64 code.  This patch adds a new bit,
>> ISA_X86_64 to generate 32bit x86-64 code or 64bit x86-64 code.  Now it
>> has
>> OPTION_MASK_ISA_64BIT           32bit x86-64 code or 64bit x86-64 code
>> OPTION_MASK_ISA_X86_64          64bit x86-64 code
>> OPTION_MASK_ISA_X32             32bit x86-64 code
>> It also extends TARGET_BI_ARCH to support
>> TARGET_BI_ARCH == 1, by default, OPTION_MASK_ISA_X86_64
>> TARGET_BI_ARCH == 2, by default, OPTION_MASK_ISA_X32
>> I also added check --with-multilib-list for x86-64 Linux targets only if
>> multilib is enabled.
>> Tested on Linux/x32.  OK for trunk?

> Hi,
> Can any build maintainers review this patch?

I don't feel comfortable reviewing this, because I don't fully
comprehend the intricacy of the interactions in this area.  It *looks*
good, but I don't trust my review abilities here.  If this has been
tested *in each of the possible modes* on x86-64, then I would approve
it, but there are an awful lot of combinations, and "Tested on
Linux/x32" does not tell me whether it works correctly on all of them.

Perhaps someone else will be more able to review this by reading through
the logic tree.

> Thanks.

Reply via email to