On 03/28/2012 09:06 PM, H.J. Lu wrote:
> On Sun, Mar 25, 2012 at 2:27 PM, Nathanael Nerode (GCC)
> <ncn_gc...@fastmail.fm> wrote:
>>
>>> Hi,
>>>
>>> Can any build maintainers review this patch?
>>
>> I don't feel comfortable reviewing this, because I don't fully
>> comprehend the intricacy of the interactions in this area. It *looks*
>> good, but I don't trust my review abilities here. If this has been
>> tested *in each of the possible modes* on x86-64, then I would approve
>> it, but there are an awful lot of combinations, and "Tested on
>> Linux/x32" does not tell me whether it works correctly on all of them.
>>
>> Perhaps someone else will be more able to review this by reading through
>> the logic tree.
>>
>>>
>>> Thanks.
>>>
>>
>
> Since OPTION_MASK_ABI_64 and OPTION_MASK_ABI_X32 have
> been added, the --with-abi= patch is much simpler. It just includes
> i386/biarchx32.h instead of i386/biarch64.h when --with-abi={x32|mx32}
> or --with-multilib-list=mx32 is used. OK for trunk?
>
> Thanks.
>
>
Yes, OK for trunk.