"Andre Vieira (lists)" <andre.simoesdiasvie...@arm.com> writes: > Here is my new version, see inline response to your comments. > > New cover letter: > > This patch enables the use of mixed-types for simd clones for AArch64, > adds aarch64 as a target_vect_simd_clones and corrects the way the > simdlen is chosen for non-specified simdlen clauses according to the > 'Vector Function Application Binary Interface Specification for AArch64'. > > gcc/ChangeLog: > > * config/aarch64/aarch64.cc (currently_supported_simd_type): > Remove. > (aarch64_simd_clone_compute_vecsize_and_simdlen): Determine > simdlen according to NDS rule. > (lane_size): New function. > > gcc/testsuite/ChangeLog: > > * lib/target-supports.exp: Add aarch64 targets to vect_simd_clones. > * c-c++-common/gomp/declare-variant-14.c: Add aarch64 checks > and remove warning check. > * g++.dg/gomp/attrs-10.C: Likewise. > * g++.dg/gomp/declare-simd-1.C: Likewise. > * g++.dg/gomp/declare-simd-3.C: Likewise. > * g++.dg/gomp/declare-simd-4.C: Likewise. > * gcc.dg/gomp/declare-simd-3.c: Likewise. > * gcc.dg/gomp/simd-clones-2.c: Likewise. > * gfortran.dg/gomp/declare-variant-14.f90: Likewise. > * c-c++-common/gomp/pr60823-1.c: Remove warning check. > * c-c++-common/gomp/pr60823-3.c: Likewise. > * g++.dg/gomp/declare-simd-7.C: Likewise. > * g++.dg/gomp/declare-simd-8.C: Likewise. > * g++.dg/gomp/pr88182.C: Likewise. > * gcc.dg/declare-simd.c: Likewise. > * gcc.dg/gomp/declare-simd-1.c: Likewise. > * gcc.dg/gomp/pr87895-1.c: Likewise. > * gfortran.dg/gomp/declare-simd-2.f90: Likewise. > * gfortran.dg/gomp/declare-simd-coarray-lib.f90: Likewise. > * gfortran.dg/gomp/pr79154-1.f90: Likewise. > * gfortran.dg/gomp/pr83977.f90: Likewise. > * gcc.dg/gomp/pr87887-1.c: Add warning test. > * gcc.dg/gomp/pr89246-1.c: Likewise. > * gcc.dg/gomp/pr99542.c: Update warning test. > > > > On 08/08/2023 11:51, Richard Sandiford wrote: >> "Andre Vieira (lists)" <andre.simoesdiasvie...@arm.com> writes: > >>> warning_at (DECL_SOURCE_LOCATION (node->decl), 0, >>> - "unsupported return type %qT for %<simd%> functions", >>> + "unsupported return type %qT for simd", >>> ret_type); >> >> What's the reason for s/%<simd%> functions/simd/, in particular for >> dropping the quotes around simd? > > It's to align with i386's error message, this helps with testing as then > I can avoid having different tests for the same error. > > I asked Jakub which one he preferred, and he gave me an explanation why > the i386's one was preferable, ... but I didn't write it down unfortunately.
Jakub: do you remember what the reason was? I don't mind dropping "function", but it feels weird to drop the quotes around "simd". Seems like, if we do that, there'll one day be a patch to add them back. :) Thanks, Richard
