On Mon, Aug 21, 2023 at 09:12:09PM +0200, Tobias Burnus wrote:
> OK. — I'd prefer if you also changed + tested a fix for my (a) + (b)
> remarks, but as those are unrelated, I understand if you don't and just
> commit your Darwin patch.
I don't like the #if !defined(__APPLE__) conditionals everywhere in the
test, I think much cleaner would be to add an effective target to test
for those functions (ideally that calls to all of them link;
all of them at once) and then use
{ dg-additional-options "-DWHATEVER" { target whatever } }
and use #ifdef WHATEVER conditionals instead.
That way any other target which doesn't have all these will not suffer from
it.
Jakub
