On Mon, Aug 21, 2023 at 09:50:37PM +0200, FX Coudert wrote:
> > I don't like the #if !defined(__APPLE__) conditionals everywhere in the
> > test, I think much cleaner would be to add an effective target to test
> > for those functions
>
> I understand, I wanted to not just report the issue but propose an option. It
> seems a bit heavy to design an effective target just for one test, though, no?
It has the advantage of getting it right on all current and future targets.
> Another possibility would be to replace #if !defined(__APPLE__) by #if
> defined(__linux__), or glibc?
If we do it, I'd still prefer one specific macro for all those spots,
TEST_NONSTANDARD_MATH_FNS or whatever and then at the start of the test
you can do either
#if !defined(__APPLE__) or #if defined(__linux__) or whatever else around
its definition.
That has the advantage of only touching one spot if one wants to add or
remove those on some other target.
Jakub
