Thanks Robin, let's wait Jeff's confirmation for this.

Pan

-----Original Message-----
From: Robin Dapp <[email protected]> 
Sent: Monday, September 18, 2023 6:01 PM
To: Jeff Law <[email protected]>; Li, Pan2 <[email protected]>; 
[email protected]
Cc: [email protected]; [email protected]; Wang, Yanzhang 
<[email protected]>; [email protected]
Subject: Re: [PATCH v1] RISC-V: Bugfix for scalar move with merged operand

> I must be missing something.  Doesn't insn 10 broadcast the immediate
> 0x2 to both elements of r142?!?  What am I missing?
It is indeed a bit misleading.  The difference is in the mask which
is not displayed in the short form.  So we actually use a vec_dup
for a single-element move, essentially a masked vec_dup where only
one element is masked in.

The problem was that the original doesn't use a merging "vec_set"
but a "destructive" one where the other elements get ignored.

The fix is OK IMHO. 

Regards
 Robin

Reply via email to