I am working on it. Currently, we have about 50+ additional FAILs after enabling vectorization.
some of them need fixed on middle-end. E.g richard fixed a missed cse optimization.
Some need fix on test case.
I am analyzing each fail one by one.
I prefer postpone this patch since it will cause some additional fails and I will handle that eventually after full coverage analysis.
---- Replied Message ----
| From | Jeff Law<jeffreya...@gmail.com> |
| Date | 10/10/2023 21:33 |
| To | juzhe.zh...@rivai.ai<juzhe.zh...@rivai.ai>, macro<ma...@embecosm.com> |
| Cc | gcc-patches<gcc-patches@gcc.gnu.org>, Robin Dapp<rdapp....@gmail.com>, Kito.cheng<kito.ch...@sifive.com>, Richard Biener<richard.guent...@gmail.com> |
| Subject | Re: [PATCH] RISC-V/testsuite: Enable `vect_pack_trunc' |
On 10/9/23 19:13, juzhe.zh...@rivai.ai wrote:
> Oh. I realize this patch increase FAIL that I recently fixed:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-October/632247.html
> <https://gcc.gnu.org/pipermail/gcc-patches/2023-October/632247.html>
>
> This fail because RVV doesn't have vec_pack_trunc_optab (Loop vectorizer
> will failed at first time but succeed at 2nd time),
> then RVV will dump 4 times FOLD_EXTRACT_LAST instead of 2 (ARM SVE 2
> times because they have vec_pack_trunc_optab).
>
> I think the root cause of RVV failing at multiple tests of "vect" is
> that we don't enable vec_pack/vec_unpack/... stuff,
> we still succeed at vectorizations and we want to enable tests of them
> (Mostly just using different approach to vectorize it (cause dump FAIL)
> because of some changing I have done previously in the middle-end).
>
> So enabling "vec_pack" for RVV will fix some FAILs but increase some
> other FAILs.
>
> CC to Richi to see more reasonable suggestions.
So what is the summary on Maciej's patch to enable vec_pack_trunc? ie,
is it something we should move forward with as-is, is it superceded by
your work in this space or does it need further investigation because of
differences in testing methodologies or something else?
jeff
