On Mon, 20 Jan 2025, Jason Merrill wrote: > On 1/20/25 4:21 AM, Jakub Jelinek wrote: > > On Mon, Jan 20, 2025 at 10:14:58AM +0100, Richard Biener wrote: > >> OK (it really makes sense). I do wonder whether there's going to be > >> more fallout similar to the OMP one - did you try grepping for SAVE_EXPR > >> checks? > > > > I saw e.g. something for the #pragma omp atomic case, but there it worst > > case just creates another TARGET_EXPR, so shouldn't be that bad. > > But I'm afraid if something else will show up we don't have covered in the > > testsuite yet. > > > >> I'm not really happy doing two different things - if we're not > >> comfortable with the trunk variant what about reverting the causing > >> change? > > > > Reverting it will result in other wrong-code issues. It is unfortunately a > > can of worms. > > I could revert r14-10839 and r14-10666 to restore the set of existing > > wrong-code issues to the 14.2 and earlier state and reapply after two months > > of getting this change tested on the trunk. > > I think your quick fix of adding save_exprs makes sense, and then we can > replace it later after this change gets more testing?
If you both agree then I'm fine with that. Richard.
