This change reminds me that we lack documentation about arguments
of most of the "complicated" internal functions ...
I didn't mention it but I got implicitly reminded several times while writing
the patch... ;) An overhaul has been on my todo list for a while but of course
it never was top priority. Ideally an adjusted API would also be useable by
SLP's argument map.
We miss internal_fn_gatherscatter_{offset,scale}_index and possibly
a internal_fn_ldst_ptr_index (always zero?) and
internal_fn_ldst_alias_align_index (always one, if supported?).
if (elsvals && icode != CODE_FOR_nothing)
get_supported_else_vals
- (icode, internal_fn_else_index (IFN_MASK_GATHER_LOAD) + 1,
*elsvals);
+ (icode, internal_fn_else_index (IFN_MASK_GATHER_LOAD), *elsvals);
these "fixes" seem to be independent?
Just realized I forgot to remove the comments. Due to the additional argument,
both optab and IFN happen to have the same arguments now. That's why the + 1
is not necessary any more.
Thanks for the comments. Will adjust, test on x86 and re-spin.
--
Regards
Robin
