Richard Henderson <richard.hender...@linaro.org> writes:
> The enable for the test was wrong, so it never ran.
>
> gcc/testsuite:
>       * gcc.target/aarch64/cmpbr.c: Use dg-require-effective-target.
> ---
>  gcc/testsuite/gcc.target/aarch64/cmpbr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/cmpbr.c 
> b/gcc/testsuite/gcc.target/aarch64/cmpbr.c
> index 34630f9a2bf..e19ca899138 100644
> --- a/gcc/testsuite/gcc.target/aarch64/cmpbr.c
> +++ b/gcc/testsuite/gcc.target/aarch64/cmpbr.c
> @@ -1,6 +1,6 @@
>  // Test that the instructions added by FEAT_CMPBR are emitted
>  // { dg-do compile }
> -// { dg-do-if assemble { target aarch64_asm_cmpbr_ok } }
> +// { dg-require-effective-target aarch64_asm_cmpbr_ok }
>  // { dg-options "-march=armv9.5-a+cmpbr -O2" }
>  // { dg-final { check-function-bodies "**" "*/" "" { target *-*-* } 
> {\.L[0-9]+} } }

Let's change it to:

/* { dg-do assemble { target aarch64_asm_cmpbr_ok } } */
/* { dg-do compile { target { ! aarch64_asm_cmpbr_ok } } } */

That was the original plan, and is used extensively in other aarch64 tests.
We changed it to use dg-do-if after Richard E pointed out that dejagnu
prior to 1.6 didn't allow the dg-do action to be conditional in this way
(see https://gcc.gnu.org/pipermail/gcc-patches/2025-May/682924.html
for a write-up).

But others have complained about dg-do-if not working either, and the
dejagnu 1.6 is 9 years old now.

Thanks,
Richard

Reply via email to