On 12/11/25 4:55 PM, Andrew Pinski wrote:
On Wed, Dec 10, 2025 at 11:00 AM Kishan Parmar <[email protected]> wrote:
On 10/12/25 10:25 pm, Andrew Pinski wrote:
The only question I have is why reject INTEGER_CST and not VECTOR_CST?
Really why reject integer cst in general?
Thanks,
Andrew
Hi Andrew,
The reason for rejecting |INTEGER_CST| is to avoid regressing rs6000 single
rotate-and-insert/mask
instructions generation.
I am still not happy with the constant check.
Can you provide a testcase where the constant check is worse? What is
the before and after check?
Attach the combine dumps if needed because the below:
Agreed. If something is behaving worse because we rejected a constant
up in gimple, then that's a sign that something is behaving badly at
expansion, RTL simplification, or target bits or all three. Rejecting
the constant feels like papering over the real issue.
Jeff
