> Hi! > > > Fix several correctness and minor issues in the fusion pair > > matching logic: > It would be nice if you could provide tests for these fusion cases. > If there is no mtune available upstream that make use of these fusions, > perhaps these can be marked XFAIL or UNSUPPORTED until that is addressed.
Hi Michiel, Thanks for the review. I agree that adding test cases is ideal. However, I would like to provide some context on why I didn't include new tests in this patch. While working on adding fusion support for XuanTie CPU cores, I noticed that riscv_macro_fusion_pair_p was becoming increasingly bloated. This structure is clearly unreasonable and difficult to maintain. Therefore, this patch is primarily a refactoring effort to improve code structure, while also fixing obvious correctness issues and minor bugs encountered during the process. Since the core logic remains largely unchanged (aside from these fixes), I initially believed the existing test suite would be sufficient. That said, if you feel that specific test cases are necessary to validate these fixes, I am happy to add them. Please let me know if you would like me to update this patch with new tests. Best regards, Jin
