On Wed, 27 May 2026 at 16:53 +0530, [email protected] wrote:
From: Dhruv Chawla <[email protected]>
Hi Jeff,
This patch regnerates configure after modifying acinclude.m4.
Thanks for the fixes, but please note that all patches for libstdc++
should be CC'd to the libstdc++ list, see
https://gcc.gnu.org/lists.html
Had you done that, I'd have pointed out that your first patch didn't
regenerate configure, and would have also noted the other problems
below ...
diff --git a/libstdc++-v3/include/bits/basic_string.h
b/libstdc++-v3/include/bits/basic_string.h
index c1871633f1b..23e6979f03d 100644
--- a/libstdc++-v3/include/bits/basic_string.h
+++ b/libstdc++-v3/include/bits/basic_string.h
@@ -4608,7 +4608,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
#endif
// _GLIBCXX_RESOLVE_LIB_DEFECTS
- // DR 1261. Insufficent overloads for to_string / to_wstring
+ // DR 1261. Insufficient overloads for to_string / to_wstring
This typo exists in the upstream issue that the comment refers to, and
I'd prefer to keep it rather than "fix" it.
See https://cplusplus.github.io/LWG/issue1261
diff --git a/libstdc++-v3/include/bits/version.h
b/libstdc++-v3/include/bits/version.h
index 517b9020ec6..ff41caa14af 100644
--- a/libstdc++-v3/include/bits/version.h
+++ b/libstdc++-v3/include/bits/version.h
This file is generated from include/bits/version.tpl so this change
will be overwritten. I'll fix the template too.
@@ -41,7 +41,7 @@
//
// This will generate the FTMs you named, and let you use them in your code as
// if it was user code. All macros are also exposed under __glibcxx_NAME even
-// if unwanted, to permit bits and other FTMs to depend on them for condtional
+// if unwanted, to permit bits and other FTMs to depend on them for conditional
// computation without exposing extra FTMs to user code.
#ifdef _GLIBCXX_SYSHDR
diff --git a/libstdc++-v3/src/c++17/fast_float/fast_float.h
b/libstdc++-v3/src/c++17/fast_float/fast_float.h
index 3da58f2850c..6a61defac93 100644
--- a/libstdc++-v3/src/c++17/fast_float/fast_float.h
+++ b/libstdc++-v3/src/c++17/fast_float/fast_float.h
This file is imported from a third-party project, changes to it should
be submitted there not just changed downstream in GCC.
I've created https://github.com/fastfloat/fast_float/pull/385 for the
first change (the second one was already fixed upstream).
@@ -60,7 +60,7 @@ struct parse_options {
/**
* This function parses the character sequence [first,last) for a number. It
parses floating-point numbers expecting
- * a locale-indepent format equivalent to what is used by std::strtod in the default
("C") locale.
+ * a locale-independent format equivalent to what is used by std::strtod in the default
("C") locale.
* The resulting floating-point value is the closest floating-point values
(using either float or double),
* using the "round to even" convention for values that would otherwise fall
right in-between two values.
* That is, we provide exact parsing according to the IEEE standard.
@@ -2924,7 +2924,7 @@ fastfloat_really_inline bool rounds_to_nearest() noexcept
{
// However, it is expected to be much faster than the fegetround()
// function call.
//
- // The volatile keywoard prevents the compiler from computing the function
+ // The volatile keyword prevents the compiler from computing the function
// at compile-time.
// There might be other ways to prevent compile-time optimizations (e.g.,
asm).
// The value does not need to be std::numeric_limits<float>::min(), any small
--
2.43.0
