On Tue, Jun 16, 2026 at 5:48 PM Andrew Pinski <[email protected]> wrote: > > On Mon, Jun 8, 2026 at 7:00 PM Léo Hardt <[email protected]> wrote: > > > > Hello! > > > > This patch removes comments that used to refer to imports, which > > were deleted in some import clean-ups that happened years ago. > > > > I did a brief tour of the code and did not notice any other such > > orphaned comment. > > > > For convenience of reviewing, here are the links to the mentioned > > commits. Notice that these diffs created the orphaned comments. > > > > - For ddg.h: > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=60393bbc > > > > - For sel-sched-ir.h: > > gcc.gnu.org/git/?p=gcc.git;a=commit;h=c7131fb > > > > - For trans-intrinsic, objc-act, objc-encoding: > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=69f293c > > > > As for testing, I don't think comments could affect the target > > binary, but I have nevertheless successfully bootstrapped gcc > > with these changes applied. > > > > gcc/ChangeLog: > > > > * ddg.h (GCC_DDG_H): Removed orphaned comment from 60393bbc > > * sel-sched-ir.h (GCC_SEL_SCHED_IR_H): Removed orphaned comment > > from c7131fb > > > > gcc/fortran/ChangeLog: > > > > * trans-intrinsic.cc: Removed orphaned comment from 69f293c > > > > gcc/objc/ChangeLog: > > > > * objc-act.cc: Removed orphaned comment from 69f293c > > * objc-encoding.cc: Removed orphaned comment from 69f293c > > Ok. (I can push it if you need someone to push it).
Now pushed as https://gcc.gnu.org/pipermail/gcc-cvs/2026-June/455691.html . Thanks, Andrea > > Thanks. > Andrea > > > > > > Signed-off-by: Léo Hardt <[email protected]> > > --- > > gcc/ddg.h | 2 -- > > gcc/fortran/trans-intrinsic.cc | 2 -- > > gcc/objc/objc-act.cc | 1 - > > gcc/objc/objc-encoding.cc | 4 ---- > > gcc/sel-sched-ir.h | 3 --- > > 5 files changed, 12 deletions(-) > > > > diff --git a/gcc/ddg.h b/gcc/ddg.h > > index b518df9b4..427b7c986 100644 > > --- a/gcc/ddg.h > > +++ b/gcc/ddg.h > > @@ -21,8 +21,6 @@ along with GCC; see the file COPYING3. If not see > > #ifndef GCC_DDG_H > > #define GCC_DDG_H > > > > -/* For sbitmap. */ > > - > > typedef struct ddg_node *ddg_node_ptr; > > typedef struct ddg_edge *ddg_edge_ptr; > > typedef struct ddg *ddg_ptr; > > diff --git a/gcc/fortran/trans-intrinsic.cc b/gcc/fortran/trans-intrinsic.cc > > index a2a6c6979..d4ec6b989 100644 > > --- a/gcc/fortran/trans-intrinsic.cc > > +++ b/gcc/fortran/trans-intrinsic.cc > > @@ -44,8 +44,6 @@ along with GCC; see the file COPYING3. If not see > > #include "realmpfr.h" > > #include "constructor.h" > > > > -/* Only for gfc_trans_assign and gfc_trans_pointer_assign. */ > > - > > /* This maps Fortran intrinsic math functions to external library or GCC > > builtin functions. */ > > typedef struct GTY(()) gfc_intrinsic_map_t { > > diff --git a/gcc/objc/objc-act.cc b/gcc/objc/objc-act.cc > > index c87670046..f656037f4 100644 > > --- a/gcc/objc/objc-act.cc > > +++ b/gcc/objc/objc-act.cc > > @@ -50,7 +50,6 @@ along with GCC; see the file COPYING3. If not see > > #include "objc-runtime-hooks.h" > > /* Routines used mainly by the runtimes. */ > > #include "objc-runtime-shared-support.h" > > -/* For default_tree_printer (). */ > > > > /* For enum gimplify_status */ > > #include "gimple-expr.h" > > diff --git a/gcc/objc/objc-encoding.cc b/gcc/objc/objc-encoding.cc > > index 7e7065b6e..10e2cedd9 100644 > > --- a/gcc/objc/objc-encoding.cc > > +++ b/gcc/objc/objc-encoding.cc > > @@ -40,8 +40,6 @@ along with GCC; see the file COPYING3. If not see > > /* For my_build_string(). */ > > #include "objc-runtime-shared-support.h" > > > > -/* For BITS_PER_UNIT. */ > > - > > /* When building Objective-C++, we are not linking against the C front-end > > and so need to replicate the C tree-construction functions in some way. > > */ > > #ifdef OBJCPLUS > > @@ -49,8 +47,6 @@ along with GCC; see the file COPYING3. If not see > > #include "objcp-decl.h" > > #endif /* OBJCPLUS */ > > > > -/* Set up for use of obstacks. */ > > - > > /* This obstack is used to accumulate the encoding of a data type. */ > > static struct obstack util_obstack; > > > > diff --git a/gcc/sel-sched-ir.h b/gcc/sel-sched-ir.h > > index b2894c952..23ca971b0 100644 > > --- a/gcc/sel-sched-ir.h > > +++ b/gcc/sel-sched-ir.h > > @@ -21,9 +21,6 @@ along with GCC; see the file COPYING3. If not see > > #ifndef GCC_SEL_SCHED_IR_H > > #define GCC_SEL_SCHED_IR_H > > > > -/* For state_t. */ > > -/* For reg_note. */ > > - > > /* tc_t is a short for target context. This is a state of the target > > backend. */ > > typedef void *tc_t; > > -- > > 2.39.5 > >
