Hi Paul-Antoine!
On 2026-07-07T17:43:14+0200, Paul-Antoine Arras <[email protected]> wrote:
> Thanks for the review. See the updated patch in attachment and my
> comments below.
Thanks! OK to push with the following items addressed.
> --- gcc/common.opt
> +++ gcc/common.opt
> +fopenmp-ompt
> +Common Var(flag_openmp_ompt) EnabledBy(fopenmp-ompt-detailed)
> +Emit additional entry points for OMPT before and after OpenMP worksharing
> constructs.
Maybe:
Emit additional calls into libgomp, enabling OMPT callbacks before and
after [...]
Is "OpenMP worksharing constructs" a good term for all the items touched
by '-fopenmp-ompt'?
> +
> +fopenmp-ompt-detailed
> +Common Var(flag_openmp_ompt_detailed)
> +Like -fopenmp-ompt, and also emit OMPT dispatch entry points.
[...], and emit additional calls into libgomp, enabling OMPT dispatch
callbacks.
That way, the user should be able to understand the cost ("additional
calls into libgomp") vs. what they get (additional OMPT callbacks)?
> --- gcc/doc/invoke.texi
> +++ gcc/doc/invoke.texi
> +@opindex fopenmp-ompt
> +@opindex fno-openmp-ompt
> +@cindex OpenMP OMPT
> +@item -fopenmp-ompt
> +Emit OMPT entry points around OpenMP worksharing constructs, so that an
> +OMPT tool can observe their start and end. Requires @option{-fopenmp}.
> +
> +@opindex fopenmp-ompt-detailed
> +@opindex fno-openmp-ompt-detailed
> +@item -fopenmp-ompt-detailed
> +Like @option{-fopenmp-ompt}, and additionally emit an OMPT dispatch
> +entry point that gets called at the beginning of each workshare chunk.
> +Requires @option{-fopenmp}.
Please update similarly to 'gcc/common.opt'.
Does '-fopenmp-ompt-detailed' also need '@cindex OpenMP OMPT'?
I assume you'll have to regenerate 'gcc/common.opt.urls'?
Grüße
Thomas
