Re: [PATCH] libstc++: Use standard FLT_EVAL_METHOD in piecewise distributions tests.

[Jonathan Wakely]

On Mon, 20 Jul 2026, 08:14 Tomasz Kamiński, <tkami...@redhat.com> wrote:

> libstdc++-v3/ChangeLog:
>
>         *
> testsuite/26_numerics/random/piecewise_constant_distribution/operators/serialize2.cc:
>         Include <cfloat> and use FLT_EVAL_METHOD instead of
> __FLT_EVAL_METHOD__.
>         *
> testsuite/26_numerics/random/piecewise_linear_distribution/operators/serialize2.cc:
>         Likewise.
> ---
> Not commited, as I was not sure if you actually asked for change.
>

I do prefer this, thanks.


> Lightly tested on x86_64-linux locally. OK for trunk?
>

OK


>  .../operators/serialize2.cc                                | 7 ++++---
>  .../piecewise_linear_distribution/operators/serialize2.cc  | 7 ++++---
>  2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git
> a/libstdc++-v3/testsuite/26_numerics/random/piecewise_constant_distribution/operators/serialize2.cc
> b/libstdc++-v3/testsuite/26_numerics/random/piecewise_constant_distribution/operators/serialize2.cc
> index 9d6eae9459f..ee5b11252cd 100644
> ---
> a/libstdc++-v3/testsuite/26_numerics/random/piecewise_constant_distribution/operators/serialize2.cc
> +++
> b/libstdc++-v3/testsuite/26_numerics/random/piecewise_constant_distribution/operators/serialize2.cc
> @@ -3,6 +3,7 @@
>  // { dg-require-cstdint "" }
>
>  #include <random>
> +#include <cfloat>
>  #include <sstream>
>  #include <testsuite_hooks.h>
>
> @@ -100,11 +101,11 @@ int main()
>    test_default<double>();
>    test_default<long double>();
>
> -#if __FLT_EVAL_METHOD__ >= 0
> -# if __FLT_EVAL_METHOD__ == 0
> +#if FLT_EVAL_METHOD >= 0
> +# if FLT_EVAL_METHOD == 0
>    test_custom<float>();
>  # endif
> -# if __FLT_EVAL_METHOD__ != 2
> +# if FLT_EVAL_METHOD != 2
>    test_custom<double>();
>  # endif
>    test_custom<long double>();
> diff --git
> a/libstdc++-v3/testsuite/26_numerics/random/piecewise_linear_distribution/operators/serialize2.cc
> b/libstdc++-v3/testsuite/26_numerics/random/piecewise_linear_distribution/operators/serialize2.cc
> index f86ed47873d..79772e20288 100644
> ---
> a/libstdc++-v3/testsuite/26_numerics/random/piecewise_linear_distribution/operators/serialize2.cc
> +++
> b/libstdc++-v3/testsuite/26_numerics/random/piecewise_linear_distribution/operators/serialize2.cc
> @@ -3,6 +3,7 @@
>  // { dg-require-cstdint "" }
>
>  #include <random>
> +#include <cfloat>
>  #include <sstream>
>  #include <testsuite_hooks.h>
>
> @@ -103,11 +104,11 @@ int main()
>    test_default<double>();
>    test_default<long double>();
>
> -#if __FLT_EVAL_METHOD__ >= 0
> -# if __FLT_EVAL_METHOD__ == 0
> +#if FLT_EVAL_METHOD >= 0
> +# if FLT_EVAL_METHOD == 0
>    test_custom<float>();
>  # endif
> -# if __FLT_EVAL_METHOD__ != 2
> +# if FLT_EVAL_METHOD != 2
>    test_custom<double>();
>  # endif
>    test_custom<long double>();
> --
> 2.55.0
>
>