On Mon, Sep 7, 2026 at 7:52 AM <[email protected]> wrote: > > From: Kyrylo Tkachov <[email protected]> > > cond_exec_process_insns and cond_exec_process_if_block document their > parameters with K&R-style comments interleaved between them, where each > comment trails the parameter it describes and so reads as if it belonged to > the next one. Move the descriptions into the function comment, which is what > the rest of the file does. Comment-only.
Ok. > > gcc/ChangeLog: > > * ifcvt.cc (cond_exec_process_insns): Document the parameters in the > function comment instead of between them. > (cond_exec_process_if_block): Likewise. > > Signed-off-by: Kyrylo Tkachov <[email protected]> > --- > gcc/ifcvt.cc | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/gcc/ifcvt.cc b/gcc/ifcvt.cc > index 3407e35de59..ca0a0861f77 100644 > --- a/gcc/ifcvt.cc > +++ b/gcc/ifcvt.cc > @@ -346,18 +346,18 @@ rtx_interchangeable_p (const_rtx a, const_rtx b) > } > > > -/* Go through a bunch of insns, converting them to conditional > - execution format if possible. Return TRUE if all of the non-note > +/* Go through the insns from START to END, converting them to conditional > + execution format if possible. CE_INFO describes the if-block being > + converted and is only read by the target IFCVT_MODIFY_INSN macro. TEST is > + the conditional-execution test to predicate them on and PROB_VAL the > + probability that it holds. MOD_OK allows one insn that modifies TEST, in > + which case it must be the last one. Return TRUE if all of the non-note > insns were processed. */ > > static bool > cond_exec_process_insns (ce_if_block *ce_info ATTRIBUTE_UNUSED, > - /* if block information */rtx_insn *start, > - /* first insn to look at */rtx end, > - /* last insn to look at */rtx test, > - /* conditional execution test */profile_probability > - prob_val, > - /* probability of branch taken. */bool mod_ok) > + rtx_insn *start, rtx end, rtx test, > + profile_probability prob_val, bool mod_ok) > { > bool must_be_last = false; > rtx_insn *insn; > @@ -476,13 +476,13 @@ cond_exec_get_condition (rtx_insn *jump, bool > get_reversed = false) > return cond; > } > > -/* Given a simple IF-THEN or IF-THEN-ELSE block, attempt to convert it > - to conditional execution. Return TRUE if we were successful at > - converting the block. */ > +/* Given a simple IF-THEN or IF-THEN-ELSE block described by CE_INFO, attempt > + to convert it to conditional execution. DO_MULTIPLE_P allows CE_INFO's > + recorded chain of && or || test blocks to be converted as well. Return > + TRUE if we were successful at converting the block. */ > > static bool > -cond_exec_process_if_block (ce_if_block * ce_info, > - /* if block information */bool do_multiple_p) > +cond_exec_process_if_block (ce_if_block *ce_info, bool do_multiple_p) > { > basic_block test_bb = ce_info->test_bb; /* last test block */ > basic_block then_bb = ce_info->then_bb; /* THEN */ > -- > 2.50.1 (Apple Git-155) >
