On 10/22/26 5:39 PM, Jeff Law wrote:
On 10/22/26 5:23 PM, Vineet Gupta wrote:
I don't want to jump the gun on the due review process but seems like
there is some feedback from gcc sashiko which Uroz shared with me [1]
and the issue it found seems legit.
[1]
https://gcc.sashiko.dev/#/patchset/20261021211758.3144964-1-vineet.gupta%40linux.dev
One more note. I was reading the LWN write-up on kernel Sashiko and one
of the issues that's been raised is some maintainers refusing to look at
patches that are not Sashiko clean. That seems like a bridge too far to
me right now for GCC. But a patch that is Sashiko clean is likely to
have a higher priority for me than one that triggers a bunch of concerns
from Sashiko.
I like to think of sashiko as good indicator of broken-ness but
mandating sashiko-clean might be too much in the other direction. As a
patch poster I can never seem to make it happy, no matter how many
versions of same patchset I'm thru. It should be maintainers call
eventually to just say that the patch is good (enough).
Thx,
-Vineet
