Hi Tobias! Do we still have reason to keep code alive for the case where 'USE_HASHTAB_LOOKUP', 'USE_HASHTAB_LOOKUP_FOR_INDIRECT' would not be '#define'd, or may I assume these are unconditionally '#define'd, and clean up that code?
For reference: On 2025-09-01T11:48:47+0200, Tobias Burnus <[email protected]> wrote: > --- a/libgomp/config/accel/target-indirect.c > +++ b/libgomp/config/accel/target-indirect.c > @@ -25,43 +25,68 @@ > [...] > +#define USE_HASHTAB_LOOKUP > + > +#ifdef USE_HASHTAB_LOOKUP > [...] > #else > --- a/libgomp/plugin/plugin-gcn.c > +++ b/libgomp/plugin/plugin-gcn.c > @@ -51,6 +51,14 @@ > [...] > +#define USE_HASHTAB_LOOKUP_FOR_INDIRECT > +#ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > +#endif > @@ -3688,37 +3696,28 @@ GOMP_OFFLOAD_load_image (int ord, unsigned version, > const void *target_data, > [...] > + #ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > + #endif > @@ -3734,9 +3733,51 @@ GOMP_OFFLOAD_load_image (int ord, unsigned version, > const void *target_data, > [...] > + #ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > + #endif > @@ -5247,4 +5288,8 @@ GOMP_OFFLOAD_openacc_destroy_thread_data (void *data) > [...] > +#ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > + #include "build-target-indirect-htab.h" > +#endif > --- a/libgomp/plugin/plugin-nvptx.c > +++ b/libgomp/plugin/plugin-nvptx.c > @@ -60,6 +60,14 @@ > [...] > +#define USE_HASHTAB_LOOKUP_FOR_INDIRECT > +#ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > +#endif > @@ -1626,39 +1634,71 @@ GOMP_OFFLOAD_load_image (int ord, unsigned version, > const void *target_data, > [...] > + #ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > + #endif > [...] > + #ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > + #endif > @@ -2898,3 +2938,7 @@ GOMP_OFFLOAD_run (int ord, void *tgt_fn, void > *tgt_vars, void **args) > [...] > +#ifdef USE_HASHTAB_LOOKUP_FOR_INDIRECT > [...] > +#endif Grüße Thomas
