Hi Thomas,

Thomas Schwinge wrote:

Do we still have reason to keep code alive for the case where
'USE_HASHTAB_LOOKUP', 'USE_HASHTAB_LOOKUP_FOR_INDIRECT' would not be
'#define'd, or may I assume these are unconditionally '#define'd, and
clean up that code?

I believe the code was mainly added to get the first
implementation of 'indirect' working before the O(n)
version was replaced by an "O(1)" version – and even
afterwards to help with debugging.

I guess that indirect is stable enough that it is not
needed anymore. When debugging a new issue in the future,
it is also likely that the current version won't help.

Thus, there should be no harm in doing the cleanup
as proposed.

Thanks,

Tobias

Reply via email to