On Mon, Nov 19, 2012 at 8:27 AM, Matthias Klose <d...@ubuntu.com> wrote:
> libgo-fix-arm.diff: Work around parse error of struct timex_ on ARM (both 
> trunk
> and 4.7 branch).
>
> libgo-hardening.diff: Avoid compiler warnings in libgo with 
> -D_FORTIFY_SOURCE=2,
> which let the build fail with -Werror. first chunk for the trunk and 4.7, 
> second
> chunk for trunk only.
>
> libgo-mksysinfo.diff: Fix TIOCNOTTY and TIOCSCTTY definitions, afaicr needed 
> for
> ARM as well. for trunk and 4.7.

Thanks.  I committed the libgo-hardening and libgo-mksysinfo patches
to mainline and 4.7 branch.


Can you tell me more about the libgo-fix-arm patch?  The patch adds
these lines to mksysinfo.sh:

+# ARM
+sed -i '/type _timex/s/INVALID-bit-field/int32/g;/type _timex/s,^//
,,' gen-sysinfo.go

I don't understand why there would an INVALID-bit-field on ARM.  This
struct comes from the <sys/timex.h>, which as far as I can see should
be the same on every glibc system.

What does struct timex look like in your <sys/timex.h> file?  What
does the line look like in gen-sysinfo.go before the sed script above
is run?

Ian

Reply via email to