Hi!
On Thu, Dec 19, 2013 at 10:13:17AM +0000, Gopalasubramanian, Ganesh wrote:
> @@ -30044,25 +30053,49 @@
> break;
> case PROCESSOR_COREI7_AVX:
> arg_str = "corei7-avx";
> - priority = P_PROC_SSE4_2;
> + priority = P_PROC_AVX;
> break;
> + case PROCESSOR_HASWELL:
> + arg_str = "core-avx2";
> + priority = P_PROC_AVX2;
> + break;
...
Please check formatting, in lots of places you are using spaces instead
of tabs.
> @@ -30922,9 +30955,13 @@
> F_SSE2,
> F_SSE3,
> F_SSSE3,
> + F_SSE4_a,
> F_SSE4_1,
> F_SSE4_2,
> F_AVX,
> + F_FMA4,
> + F_XOP,
> + F_FMA,
> F_AVX2,
> F_MAX
> };
I think the F_* constants, like the differences of M_* constants
from the preceeding M_*_START value, are part of the ABI, so you can't
reorder them. Also, if the enum names are all capital letters, using
F_SSE4_a instead of F_SSE4_A looks inconsistent.
> @@ -30943,6 +30980,10 @@
> M_AMDFAM10H,
> M_AMDFAM15H,
> M_INTEL_SLM,
> + M_INTEL_COREI7_AVX,
> + M_INTEL_CORE_AVX2,
> + M_AMD_BTVER1,
> + M_AMD_BTVER2,
> M_CPU_SUBTYPE_START,
> M_INTEL_COREI7_NEHALEM,
> M_INTEL_COREI7_WESTMERE,
> @@ -30953,7 +30994,9 @@
> M_AMDFAM15H_BDVER1,
> M_AMDFAM15H_BDVER2,
> M_AMDFAM15H_BDVER3,
> - M_AMDFAM15H_BDVER4
> + M_AMDFAM15H_BDVER4,
> + M_INTEL_COREI7_IVYBRIDGE,
> + M_INTEL_CORE_HASWELL
> };
>
> static struct _arch_names_table
> @@ -89,9 +97,13 @@
> FEATURE_SSE2,
> FEATURE_SSE3,
> FEATURE_SSSE3,
> + FEATURE_SSE4_a,
> FEATURE_SSE4_1,
> FEATURE_SSE4_2,
> FEATURE_AVX,
> + FEATURE_FMA4,
> + FEATURE_XOP,
> + FEATURE_FMA,
> FEATURE_AVX2
> };
>
Ditto here.
Jakub
