On Wed, Feb 05, 2014 at 10:43:24AM +0100, Marc Glisse wrote:
> On Wed, 5 Feb 2014, Dominique Dhumieres wrote:
>
> >>I'll give it a day (it can easily be changed again later).
> >
> >IMO it would be better (more general) to use a dg-require-effective-target
> >with the corresponding test(s) in target-supports-dg.exp.
>
> But which tests? One for over/under alignment of functions, one for
> init_priority, maybe yet one more, all that for a file that is just
> checking that the parser understands the attribute argument is a
> constant...
>
> I agree on the principle, but unless those tests already exist, it
> doesn't seem worth it (well, if you are volunteering to write them,
> I certainly won't object).
Yeah, the tests really don't test anything target specific, but test it
on attributes that have target specific meaning/applicability.
So it is enough to catch it on some most widely tested targets, any
regression in that area will be known the same day when it breaks.
Jakub
