> -----Original Message-----
> From: Jakub Jelinek [mailto:ja...@redhat.com]
> Sent: Wednesday, February 5, 2014 2:25 PM
> To: Iyer, Balaji V
> Cc: Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Re: regression test issue
> 
> On Wed, Feb 05, 2014 at 07:08:32PM +0000, Iyer, Balaji V wrote:
> > Sorry, I forgot to put [PATCH] in the subject line. Is the patch below OK to
> install?
> 
> No.  If you want to skip a particular test, you should use dg-skip-if for 
> that,
> see http://gcc.gnu.org/onlinedocs/gccint/Directives.html

Ok. Here is the fixed patch:

Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog     (revision 207437)
+++ gcc/testsuite/ChangeLog     (working copy)
@@ -1,3 +1,8 @@
+2014-02-05  Balaji V. Iyer  <balaji.v.i...@intel.com>
+
+       * g++.dg/cilk-plus/CK/catch_exc.cc: Disable test for -O1
+       * c-c++-common/cilk-plus/CK/spawner_inline.c: Likewise.
+
 2014-02-03  Marc Glisse  <marc.gli...@inria.fr>

        PR c++/53017
Index: gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc
===================================================================
--- gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc      (revision 207437)
+++ gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc      (working copy)
@@ -1,6 +1,7 @@
 /* { dg-options "-fcilkplus" } */
 /* { dg-do run { target i?86-*-* x86_64-*-* arm*-*-* } } */
 /* { dg-options "-fcilkplus -lcilkrts" { target { i?86-*-* x86_64-*-* arm*-*-* 
} } } */
+/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */

 #include <assert.h>
 #include <unistd.h>
Index: gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c
===================================================================
--- gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c    (revision 
207437)
+++ gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c    (working copy)
@@ -1,6 +1,7 @@
 /* { dg-do run  { target { i?86-*-* x86_64-*-* } } } */
 /* { dg-options "-fcilkplus" } */
 /* { dg-additional-options "-lcilkrts" { target { i?86-*-* x86_64-*-* } } } */
+/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */

OK to install?

Thanks,
Balaji V. Iyer.

> 
>       Jakub

Reply via email to