> -----Original Message-----
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-
> ow...@gcc.gnu.org] On Behalf Of Rainer Orth
> Sent: Wednesday, February 5, 2014 4:22 PM
> To: Iyer, Balaji V
> Cc: Jakub Jelinek; Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Re: regression test issue
>
> "Iyer, Balaji V" <balaji.v.i...@intel.com> writes:
>
> > Index: gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc
> >
> ==========================================================
> =========
> > --- gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc (revision 207437)
> > +++ gcc/testsuite/g++.dg/cilk-plus/CK/catch_exc.cc (working copy)
> > @@ -1,6 +1,7 @@
> > /* { dg-options "-fcilkplus" } */
> > /* { dg-do run { target i?86-*-* x86_64-*-* arm*-*-* } } */
> > /* { dg-options "-fcilkplus -lcilkrts" { target { i?86-*-* x86_64-*-*
> > arm*-*-* } } } */
> > +/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */
> >
> > #include <assert.h>
> > #include <unistd.h>
> > Index: gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c
> >
> ==========================================================
> =========
> > --- gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c (revision
> 207437)
> > +++ gcc/testsuite/c-c++-common/cilk-plus/CK/spawner_inline.c (working
> copy)
> > @@ -1,6 +1,7 @@
> > /* { dg-do run { target { i?86-*-* x86_64-*-* } } } */
> > /* { dg-options "-fcilkplus" } */
> > /* { dg-additional-options "-lcilkrts" { target { i?86-*-* x86_64-*-*
> > } } } */
> > +/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */
>
> You should put a comment (e.g. a PR reference) in the comment field to
> explain why you're skipping this test. Most likely, the last arg to
> dg-skip-if ({
> "" }) is optional; if so, please omit it.
There isn't a PR reference for this. I can add a comment in the testcase. Would
that be enough?
I will also remove the last {""} from the tests.
Thanks,
Balaji V. Iyer.
>
> Thanks.
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
