Kai Tietz <ktiet...@googlemail.com> writes:

> 2014-03-19 17:23 GMT+01:00 Mike Stump <mikest...@comcast.net>:
>> On Mar 18, 2014, at 6:16 AM, Kai Tietz <ktiet...@googlemail.com> wrote:
>>> this patch skips anon2.C and anon3.C test for mingw target.  Issue
>>> here is that weak under pe-coff is different to ELF-targets and
>>> therefore test doesn't apply for
>>
>> So, what does the output look like?  There should be a trace of weak of
>> some sort in the output.
>
> No, there is none.  Output looks like:
>
>         .seh_proc       _ZN2N43._91CIiE3fn2ES2_
> _ZN2N43._91CIiE3fn2ES2_:
> .LFB11:
>         .seh_endprologue
>         ret
>         .seh_endproc
>         .globl  _ZN2N41qE
>         .data
>         .align 8
> _ZN2N41qE:
>         .quad   _ZN2N43._91CIiE3fn2ES2_
>         .globl  _ZN2N41pE
>         .align 8
> _ZN2N41pE:
>         .quad   _ZN2N43._91CIiE3fn1ENS0_1BE
>         .globl  _ZN2N31qE
>         .align 8
> _ZN2N31qE:
>         .quad   _ZN2N31D1CIiE3fn2ES2_...
>
> The concept of weak - as present in ELF - isn't known in COFF in
> general.  There is some weak, but it works only for static library and
> in a limitted way.  Therefore we can't (and don't) use it for COFF
> targets.

In that case, it seems far better to have
gcc/testsuite/lib/target-support.exp (check_weak_available) reflect that
instead of lying about weak support.

This way, everything else simply falls into place; no need to
special-case many individual testcases.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to