On Thu, 21 Aug 2014, Mike Stump wrote: > On Aug 21, 2014, at 10:59 AM, Sandra Loosemore <san...@codesourcery.com> > wrote: > > On 08/21/2014 11:36 AM, Mike Stump wrote: > >> On Aug 21, 2014, at 8:00 AM, Sandra Loosemore > >> <san...@codesourcery.com> wrote: > >>> tests that assume some non-default branch costs in the back end > >> > >> Thanks. > >> > >> One comment, could you put in /* non default branch cost */ above the > >> three where that is true. > > > > The three what? :-S > > Sorry, I meant 4? Your patch has four instances of this change: > > -/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* > powerpc*-*-* xtensa*-*-* hppa*-*-*"} } } */ > +/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* > powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-*"} } } */ > > see your patch for them. Can you change the patch effectively to: > > -/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* > powerpc*-*-* xtensa*-*-* hppa*-*-*"} } } */ > +/* non default branch cost */ > +/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* > powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-*"} } } */ > > instead? The comment serves as documentation as to what all > the listed targets have in common. A person doing a new port, > can then read the comment, and say I am non-default branch cost, > so add me, or alternatively, I am the default, this failure is a > bug I need to investigate and fix.
It's the other way round re "listed targets". (CRIS and MMIX have the default branch cost, ditto m68k and moxie, didn't check the others.) brgds, H-P