On Sat, 23 Aug 2014, Sandra Loosemore wrote: > On 08/23/2014 10:26 AM, Mike Stump wrote: > > On Aug 22, 2014, at 3:48 PM, Hans-Peter Nilsson <h...@bitrange.com> wrote: > > > > > > > +/* non default branch cost */ > > > > +/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* > > > > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* > > > > mcore*-*-* powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-*"} } } */ > > > > > It's the other way round re "listed targets". (CRIS and MMIX > > > have the default branch cost, ditto m68k and moxie, didn't check > > > the others.) > > > > Right. I had ! on the brain. Do you like non-default branch cost, or would > > it > > be better to describe it some other way? > > If we're going to go through the trouble of adding a comment here, we might as > well make it something less terse and more explicit, like: > > These tests fail unless the target backend overrides BRANCH_COST to return a > value >= 2.
Agreed! The target list line is getting longish, maybe put it in an effective-target proc while it's being edited anyway. brgds, H-P