> On Sep 2, 2014, at 1:36 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > >> On Tue, Sep 2, 2014 at 9:22 AM, Andrew Pinski wrote: >>> On Tue, Sep 2, 2014 at 12:20 AM, Andi Kleen wrote: >>> >>>> there have been bugs in the past in the area of always_inline too. >>> >>> You're arguing for my patch. It would find those bugs. >> >> >> No I am arguing against it since the older versions of GCC we cannot change. > > Should such bugs turn up, we can account for them in ansidecl.h. > > I think Andi's patch should go in.
I does hurt debug ability with older compilers too. So if we need to figure out why stage is being miscompiled it is harder to figure how to work around it. I think stage should really be -O0 even with respect of inline. I think we should never force inline inside gcc even at -O0 as it is just a hack (we know it as we added the attribute in the first place). Thanks, Andrew > > Ciao! > Steven
