On Tue, Sep 2, 2014 at 10:36 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > On Tue, Sep 2, 2014 at 9:22 AM, Andrew Pinski wrote: >> On Tue, Sep 2, 2014 at 12:20 AM, Andi Kleen wrote: >>> >>>> there have been bugs in the past in the area of always_inline too. >>> >>> You're arguing for my patch. It would find those bugs. >> >> >> No I am arguing against it since the older versions of GCC we cannot change. > > Should such bugs turn up, we can account for them in ansidecl.h. > > I think Andi's patch should go in.
I disagree. always-inline isn't an optimization attribute but a correctness one. Instead we should not build stage1 with -O0 if we detect a reasonably recent GCC host compiler (say one that is still maintained). Or we simply should make -finline work at -O0 (I suppose it might already work?) and use it. Richard. > Ciao! > Steven
