On Wed, Sep 24, 2014 at 9:13 PM, Michael Collison <michael.colli...@linaro.org> wrote: > > I have that attached to the bug report at the URL provided. I will work on a > testcase if you think it is warranted.
Yes it is almost always warranted. https://gcc.gnu.org/contribute.html#patches Testcases If you cannot follow the recommendations of the GCC coding conventions about testcases, you should include a justification for why adequate testcases cannot be added. See the last part of that sentence. You don't have any justification on why you are not including testcases. -- Pinski > > > On 09/24/2014 09:10 PM, Andrew Pinski wrote: >> >> On Wed, Sep 24, 2014 at 9:08 PM, Michael Collison >> <michael.colli...@linaro.org> wrote: >>> >>> Testcase attaached. Reproduce with "g++ -c -O2 -fPIE". URL for more >>> detailed >>> description: >>> >>> https://bugs.linaro.org/show_bug.cgi?id=331 >> >> It would be a good idea to get a reduced testcase that you could add >> to the GCC testsuite so this won't show up again. >> >> Thanks, >> Andrew Pinski >> >>> >>> >>> On 09/24/2014 09:01 PM, Andrew Pinski wrote: >>>> >>>> On Wed, Sep 24, 2014 at 8:45 PM, Michael Collison >>>> <michael.colli...@linaro.org> wrote: >>>>> >>>>> On certain patterns in atomics.md the constraint 'n' is used in >>>>> combination >>>>> with the predicate atomic_op_operand. The constraint is too general and >>>>> allows constants that are disallowed by the predicate. This causes an >>>>> ICE >>>>> In >>>>> final_scan_insn when the insn cannot be split because the constraint >>>>> and >>>>> predicate do not match. >>>>> >>>>> Tested on aarch64-none-elf, aarch64-linux-gnu. Additionally the >>>>> originally >>>>> reporter of the bug, (d...@ubuntu.com), applied the patch and >>>>> successfully >>>>> bootstrapped and tested with no regressions. >>>> >>>> Testcase? >>>> >>>>> 2014-09-23 Michael Collison <michael.colli...@linaro.org> >>>>> >>>>> * config/aarch64/iterators.md (lconst_atomic): New mode attribute >>>>> to >>>>> support constraints for CONST_INT in atomic operations. >>>>> * config/aarch64/atomics.md >>>>> (atomic_<atomic_optab><mode>): Use lconst_atomic constraint. >>>>> (atomic_nand<mode>): Likewise. >>>>> (atomic_fetch_<atomic_optab><mode>): Likewise. >>>>> (atomic_fetch_nand<mode>): Likewise. >>>>> (atomic_<atomic_optab>_fetch<mode>): Likewise. >>>>> (atomic_nand_fetch<mode>): Likewise. >>>>> >>>>> -- >>>>> Michael Collison >>>>> Linaro Toolchain Working Group >>>>> michael.colli...@linaro.org >>>>> >>> -- >>> Michael Collison >>> Linaro Toolchain Working Group >>> michael.colli...@linaro.org >>> > > -- > Michael Collison > Linaro Toolchain Working Group > michael.colli...@linaro.org >
