On Wed, 29 Oct 2014, Kyrill Tkachov wrote: > Hi all, > > This fixes an arm build failure due to removing the 'enum' keyword from > machine_mode. > Since libgcc2 is compiled with C rather than C++ we need it there for the > definition of CUMULATIVE_ARGS.
But why is CUMULATIVE_ARGS needed for libgcc? It's desirable to eliminate use of host-side headers in target-side code (I'd welcome more people picking up pieces of the target macros work described at <https://gcc.gnu.org/wiki/Top-Level_Libgcc_Migration>, though you shouldn't rely on the distinctions there about where I suggest a particular macro should move; it's quite likely there are better choices in various cases). Thus, if something in host-side headers is causing problems in target-side code, I'd think the obvious fix is to condition out the relevant code when building for the target, rather than fixing it to work (although meaningless) for the target. -- Joseph S. Myers jos...@codesourcery.com
