On Fri, 2 Feb 2024, Bernhard Reutner-Fischer via Gcc wrote: > Hi Joseph! > > On Tue, 30 Jan 2024 14:54:49 +0000 (UTC) > Joseph Myers <josmy...@redhat.com> wrote: > > > On Tue, 30 Jan 2024, Bernhard Reutner-Fischer via Gcc wrote: > > > > > * builtin-attrs.def (ATTR_TM_NOTHROW_RT_LIST): Use ATTR_NOTHROW_LIST > > > instead of ATTR_TM_NOTHROW_LIST, thus removing ATTR_TM_REGPARM. > > > > That doesn't make sense. ATTR_TM_NOTHROW_RT_LIST is specifically a > > transactional memory attribute list, but you're removing all transactional > > memory attributes from it. A list without the "*tm regparm" internal > > attribute would have a different name. > > > > AFAICS there is no pre-existing attr list with just returns_twice and > nothrow. Would ATTR_NOTHROW_RT_LIST be more appropriate as name, and > should i move this up to before the format attribute lists, before > DEF_FORMAT_ATTRIBUTE?
Yes, both of those seem appropriate for such an attribute list. I do not know what attributes are appropriate for _ITM_beginTransaction. -- Joseph S. Myers josmy...@redhat.com
